tunnelvisionlabs / ReferenceAssemblyAnnotator

IL weaver to add nullability annotations to .NET reference assemblies
MIT License
71 stars 8 forks source link

Remove the notnull constraint from IDictionary<TKey, TValue> keys #52

Closed sharwell closed 3 years ago

sharwell commented 5 years ago

This will work around dotnet/corefx#42386 for the 3.x releases until the constraint is removed for .NET 5.

jnm2 commented 4 years ago

The constraint should also be removed from IReadOnlyDictionary and several extension methods. This is the diff to follow: https://github.com/dotnet/runtime/commit/48a78bfa13e9c710851690621fc2c0fe1637802c

The notnull constraint was removed from the TKey generic parameter of:

jnm2 commented 3 years ago

@sharwell This can be closed now that 5.0.0 annotations are out. We might also want to update the code snippets in the readme to use 5.0.0.

jnm2 commented 3 years ago

@sharwell Readme update is ready: #88