Fix assembly resolution for more target frameworks

tunnelvisionlabs / ReferenceAssemblyAnnotator

IL weaver to add nullability annotations to .NET reference assemblies

MIT License

71 stars 8 forks source link

Fix assembly resolution for more target frameworks #59

Closed jnm2 closed 4 years ago

jnm2 commented 4 years ago

Fixes #38 Fixes #50 Supersedes #49

I verified that source attributes are added by default when appropriate and rewritten assemblies are being used by CscTask for <TargetFrameworks>net35;net48;netstandard1.6;netstandard2.0;netstandard2.1;netcoreapp2.1;netcoreapp3.0;netcoreapp3.1</TargetFrameworks>.

sharwell commented 4 years ago

@jnm2 The process for adding a new test framework is shown in #61. Can you add the following frameworks to this pull request:

netstandard2.1
netcoreapp2.0
netcoreapp2.1
netcoreapp3.0
netcoreapp3.1

jnm2 commented 4 years ago

@sharwell Tests pass, ready for review! I didn't put any effort into making things pretty (out of time). Maybe the netstandard1.6 sections could be unified with the netcoreapp1.x sections.