tunnelvisionlabs / ReferenceAssemblyAnnotator

IL weaver to add nullability annotations to .NET reference assemblies
MIT License
72 stars 8 forks source link

BCL Intellisense not working #80

Open mikernet opened 4 years ago

mikernet commented 4 years ago

BCL Intellisense stops working when the alpha.154 package is added to a .NET Standard 2.1 library.

jnm2 commented 4 years ago

I saw this as well.

mikernet commented 4 years ago

Any idea why this could be happening? The path obj\Release\netstandard2.1\annotated contains netstandard.xml so I have no idea what to do to fix this.

mikernet commented 4 years ago

It seems to be hit and miss as to which IntelliSense still works and I can't really figure out what the pattern is.

Working examples:

Non-working examples:

I could be wrong but I think more of the BCL IntelliSense started working after I upgraded to VS 16.5.0...I'm fairly sure the working examples above were not working before.

jnm2 commented 4 years ago

@mikernet Is this still happening? In VS 16.6.5 I'm getting intellisense for all the above in a project using this in Directory.Build.props:

  <ItemGroup>
    <PackageReference Include="TunnelVisionLabs.ReferenceAssemblyAnnotator" Version="1.0.0-alpha.154" PrivateAssets="all" />
    <PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[3.1.0]" />
  </ItemGroup>
mikernet commented 4 years ago

The situation got even worse...not only do I not have intellisense, but I also can't F1 on members to get to docs - it just always goes to https://docs.microsoft.com/en-us/ :/

mikernet commented 4 years ago

I think it just so happens that MSDN broke right after I upgraded VS, haha. Bad timing. Intellisense still borked though.

jnm2 commented 4 years ago

@mikernet Is there a repro project I can look at? It's all working for me in a net472 project with VS 16.6.5, 3.1.0 annotations, and the latest two versions of RAA.

Also did you git clean -xdf since the last time you changed any of these version numbers?

mikernet commented 4 years ago

Seems it works for some but not for others. Not working for https://github.com/Singulink/Singulink.IO.FileSystem.

Could be netstandard 2.0 v.s. 2.1?