search

tunnelvisionlabs / antlr4

The highly-optimized fork of ANTLR 4 (see README)
Other
73 stars 12 forks source link

Improve the performance of failed semantic predicate #55

Closed daniellansun closed 4 years ago

daniellansun commented 5 years ago

Try to fix https://github.com/tunnelvisionlabs/antlr4/issues/53

daniellansun commented 5 years ago

Build successfully on appveyor, but failed on travis because installing JDK failed:

The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .
codecov-io commented 5 years ago

Codecov Report

Merging #55 into master will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   61.33%   61.34%   +0.01%     
==========================================
  Files         373      373              
  Lines       18838    18838              
  Branches     3604     3604              
==========================================
+ Hits        11555    11557       +2     
  Misses       6012     6012              
+ Partials     1271     1269       -2
Impacted Files Coverage Δ
...org/antlr/v4/runtime/FailedPredicateException.java 42.85% <ø> (ø) :arrow_up:
.../org/antlr/v4/runtime/misc/NullUsageProcessor.java 66.91% <0%> (+0.73%) :arrow_up:
...src/org/antlr/v4/runtime/dfa/SingletonEdgeMap.java 30.61% <0%> (+2.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be01739...2bd3930. Read the comment docs.

daniellansun commented 5 years ago

All tests pass, and the issue failing to install JDK is fixed too.

daniellansun commented 4 years ago

@sharwell I have modified the PR according to your suggestion, please review it again :-)