search

tunnelvisionlabs / antlr4ts

Optimized TypeScript target for ANTLR 4
Other
624 stars 106 forks source link

The JDK_SOURCE_ROOT environment variable must be set for performance testing. #451

Open BurtHarris opened 4 years ago

BurtHarris commented 4 years ago

npm run benchmark fails on my new machine with the message above. It comes from TestPerformance.ts.

@sharwell, I remember that one of the benchmark requirements involved getting a copy of this code that was under a sun/oracle license, and setting this environment variable. I don't recall where to get it.

I'm wondering, does OpenJDK now have equivalent code that doesn't call for under a propitiatory license? Would it make sense to include it via sub-module? Could we then eliminate the need for the environment variable?

BurtHarris commented 4 years ago

Sam, if possible lets load go the sub-module approach so that benchmark will run after npm install. Your feedback is important.

BurtHarris commented 4 years ago

@sharwell can you please remind me where to find the source code needed to run benchmark?