search

tunnelvisionlabs / antlr4ts

Optimized TypeScript target for ANTLR 4
Other
624 stars 106 forks source link

Visitor classes lack visit(), visitChildren() etc... #473

Closed BurtHarris closed 4 years ago

BurtHarris commented 4 years ago

I'm running antlr4ts -visitor -no-listener LabeledExpr.g4.

The resulting LabeledExprVisitor.ts (an interface) has methods like visitAssign() does not implement the visit() method declared in ParseTreeVisitor.ts's ParseTreeVisitor<Result> interface.

BurtHarris commented 4 years ago

My confusion, closing

BurtHarris commented 4 years ago

Reopening. Probably related to #398... Found implementation in class AbstractParseTreeVisitor I guess my visitor needs to be something like:

export class EvalVisitor 
            extends AbstractParseTreeVisitor<number> 
            implements LabeledExprVisitor<number> { ...