search

tunoltd / emoji-mart-native

One component to pick them all 👊🏼
https://tunoltd.github.io/emoji-mart-native
BSD 3-Clause "New" or "Revised" License
86 stars 31 forks source link

fix(spriteSheetFn): the default spriteSheetFn prop is broken #193

Closed sibelius closed 4 years ago

sibelius commented 4 years ago

the default spriteSheetFn prop is broken

it was returning undefined instead of { uri }

pederjohnsen commented 4 years ago

@sibelius nice catch 🎉

It's failing the prettier checks in the tests though 🤔

sibelius commented 4 years ago

feel free to fix it

I think you should add lint-staged to apply prettier at each commit

pederjohnsen commented 4 years ago

@sibelius done :), and yeah that's probably a good idea, will add to my todos 👌

I'll get this merged and put live later today 🚀

sibelius commented 4 years ago

what is the fastest way to show emojis?

pederjohnsen commented 4 years ago

@sibelius just released v0.6.2-beta with your fix, thanks :ok_hand:

Performance wise the best option currently seems to be using sprite sheets, especially when adding the sheet resources to the app package (https://github.com/tunoltd/emoji-mart-native#spritesheetfn). However due to a bug with React Native and Fresco using sprite sheets on Android produces a slightly blurry result.