Deterministic sorting of search results

tunoltd / emoji-mart-native

One component to pick them all 👊🏼

https://tunoltd.github.io/emoji-mart-native

BSD 3-Clause "New" or "Revised" License

86 stars 31 forks source link

Deterministic sorting of search results #62

Closed xaviershay closed 5 years ago

xaviershay commented 5 years ago

This is important for reliable tests, e.g. if you are snapshotting views and comparing to reference images.

pederjohnsen commented 5 years ago

Hey @xaviershay!

Thanks for this PR, however when it comes to the core code shared with https://github.com/missive/emoji-mart I prefer porting changes from there as improvements are added. Could you suggest your PR there first? :)

xaviershay commented 5 years ago

here you go! https://github.com/missive/emoji-mart/pull/343

johnsenpeder commented 5 years ago

@xaviershay great thanks :+1:

johnsenpeder commented 5 years ago

@xaviershay sorry, just closed and re-opened this to force a travis ci build. You'll need to run yarn prettier for this PR and the emoji-mart one to fix the errors :)

johnsenpeder commented 5 years ago

@xaviershay just published new version to npm with these changes :ok_hand: :rocket:

xaviershay commented 5 years ago

love your work ❤️ 🙏