search

tuntorius / mightier_amp

An alternative app for controlling NUX Mighty amps.
MIT License
178 stars 18 forks source link

No more labels for sliders #61

Closed antonio-petricca closed 1 year ago

antonio-petricca commented 1 year ago

Hi, all the labels for sliders have disappeared. It no more possibile to change any settings.

The application unfortunately is no more useful.

Is it possibile to fix it?

Thank you so much! :)

tuntorius commented 1 year ago

Are you using google talkback?

antonio-petricca commented 1 year ago

No, I don't.

Il Lun 13 Mar 2023, 21:58 tuntorius @.***> ha scritto:

Are you using google talkback?

— Reply to this email directly, view it on GitHub https://github.com/tuntorius/mightier_amp/issues/61#issuecomment-1466946936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS2CIUCPBCQRO25Q5HVEZLW36C75ANCNFSM6AAAAAAVZSBVAE . You are receiving this because you authored the thread.Message ID: @.***>

antonio-petricca commented 1 year ago

This is the situation:

Il Lun 13 Mar 2023, 23:02 Antonio Petricca @.***> ha scritto:

No, I don't.

Il Lun 13 Mar 2023, 21:58 tuntorius @.***> ha scritto:

Are you using google talkback?

— Reply to this email directly, view it on GitHub < https://github.com/tuntorius/mightier_amp/issues/61#issuecomment-1466946936 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABS2CIUCPBCQRO25Q5HVEZLW36C75ANCNFSM6AAAAAAVZSBVAE

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tuntorius/mightier_amp/issues/61#issuecomment-1467026802, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS2CIVCLTCUAZZOPNB37ODW36KOVANCNFSM6AAAAAAVZSBVAE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cho45 commented 1 year ago

I reproduce this in my environment. (v0.9.9/Android13)

However, immediately after startup, the label is displayed without any problem. The label disappears when I perform operations such as selecting tabs.

Screenshot_20230314-111535

Can accessibleNavigation here unintentionally be true?https://github.com/tuntorius/mightier_amp/blob/1f2c9a216825545c6632c749b4d74e1a75b7f4fa/lib/UI/widgets/thickSlider.dart#L193-L214

antonio-petricca commented 1 year ago

Unfortunately the issue is still present in 0.9.9.

Il Mar 14 Mar 2023, 03:17 Satoh, Hiroh @.***> ha scritto:

I reproduce this in my environment. (v0.9.9/Android13)

However, immediately after startup, the label is displayed without any problem. The label disappears when I perform operations such as selecting tabs.

[image: Screenshot_20230314-111535] https://user-images.githubusercontent.com/3092/224875444-e73d6de9-cf03-4cc3-9851-043f56b31dc4.png

— Reply to this email directly, view it on GitHub https://github.com/tuntorius/mightier_amp/issues/61#issuecomment-1467239988, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS2CIXUGDPEHPX3Q5D2UHDW37IK5ANCNFSM6AAAAAAVZSBVAE . You are receiving this because you authored the thread.Message ID: @.***>

tuntorius commented 1 year ago

I'm not sure why the accessibility mode is triggering for you. @cho45 just like you pointed out, the check if accessibility feature is enabled is so simple that it's impossible to get wrong. That property - "accessibleNavigation" is not written by me. It's part of the MediaQuery class from the flutter framework. I'm just doing a simple 'if' check. The only explanation is a bug in it. It works for me and I haven't heard about this problem from other people. I also did a search for a bug in it but haven't found any posts or issues about it. I guess I'll replace it with native android code that checks. Hopefully, that one will work correctly.

The reason behind those sliders is that I was contacted a few times by blind people, who asked me if I can make the sliders work with the accessibility features. The easiest solution was to detect if a reader is active and replace them with standard ones, which are designed with that in mind.

cho45 commented 1 year ago

I looked for something in my Android settings that would turn on "accessibleNavigation" and found that Bitwarden was enabled in "Accessibility". When I tried turning Bitwarden off, this issue did not reproduce.

It appears that flutter's accessibleNavigation in Android can be turned on for functions other than screen readers.

I don't know why "accessibleNavigation" is false only immediately after startup, but I think this is another issue.

antonio-petricca commented 1 year ago

I tried enabling/disabling Talkback and nothing happened.

I reinstalled your wonderful app, but nothing happened again.

:(

antonio-petricca commented 1 year ago

Issue solved: I removed all of my 4 four apps from accessibility!

tuntorius commented 1 year ago

Great that you found the reason, but it still is not the perfect solution if you want to keep those apps. I think I successfully added accessibility functions to my custom sliders, so the next version will not use accessibleNavigation.

antonio-petricca commented 1 year ago

Great! Thank you so much again!

Il Mer 15 Mar 2023, 21:12 tuntorius @.***> ha scritto:

Great that you found the reason, but it still is not the perfect solution if you want to keep those apps. I think I successfully added accessibility functions to my custom sliders, so the next version will not use accessibleNavigation.

— Reply to this email directly, view it on GitHub https://github.com/tuntorius/mightier_amp/issues/61#issuecomment-1470775920, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS2CIXDDI6VMAS2343BIE3W4IPETANCNFSM6AAAAAAVZSBVAE . You are receiving this because you modified the open/close state.Message ID: @.***>