tuomashatakka / reduced-dark-ui

Minimal yet functional dark theme for atom.io
MIT License
9 stars 0 forks source link

Weird settings #11

Closed alanzanattadev closed 7 years ago

alanzanattadev commented 7 years ago

Hi,

I've discovered a weird bug, it seems that settings are sometimes like the old version, and sometimes like the new (with sliders), very very weird, I don't know why it switches like that

Thank you

tuomashatakka commented 7 years ago

It's because it is bound to the onDidChangeActivePaneItem event. If the settings tab is opened initially with the editor, the hook is not triggered. There seems to be other cases as well where the hook is not triggered, I am working on fixing them :)

For now, switching away from the settings tab and then switching back should activate them.

tuomashatakka commented 7 years ago

The sliders are broken for now - I am replacing them with native html slider inputs, so they should ve fine after the next update

tuomashatakka commented 7 years ago

Got this finally working almost always. Sometimes returns an empty view on initialization though