search

tuomashatakka / reduced-dark-ui

Minimal yet functional dark theme for atom.io
MIT License
9 stars 0 forks source link

TabBar not sliding #14

Closed alanzanattadev closed 7 years ago

alanzanattadev commented 7 years ago

Hi,

when I use the colloapsable tree-view, it works good for the tree-view and the code buffer view, but when I come back to a fixed tree-view by clicking on the icon, the tab-view doesn't slide like the code buffer, making it a little bit hidden by the tree-view

Thank you

tuomashatakka commented 7 years ago

I just understood what you mean, after playing with theme settings :D The sliding should be observed more thoroughly. There is also an issue with sliding when multiple panes are present - only the active (or first, donut remember) pane is given a margin.

alanzanattadev commented 7 years ago

Be careful of not having a theme so dependant of the number of plugins installed or whatever, because this kind of feature can become a nightmare with multiple panes added by plugins :D

tuomashatakka commented 7 years ago

That is why the toggles for the panels are so small ;) But good point. I've tried to keep the dependencies and the premise as simple as possible - i even uninstalled all packagesvthe other day! (It was an accident though 😂😂) Actually tool-bar, tabs and tree-view are the only packages I've put any extra thought. Better to try to generalize everything since in atom you can make no assumptions about the architecture of plugins 😃

Good thing is it can always be disabled if it doesn't work well with a specific plugin.

tuomashatakka commented 7 years ago

I think this was resolved earlier already. I'll close this and reopen if it looks like this is still an issue.