search

tuomashatakka / reduced-dark-ui

Minimal yet functional dark theme for atom.io
MIT License
9 stars 0 forks source link

Success icon not aligned in notification #6

Closed alanzanattadev closed 7 years ago

alanzanattadev commented 7 years ago

Hi,

the success icon is aligned to the top instead of the center in the green part of the notification :)

Thank you

tuomashatakka commented 7 years ago

Could you send a screenshot? Shouldn't the icons be aligned to the top?

alanzanattadev commented 7 years ago

It does something like :

x The notification message

instead of

The notification message x <= centered

Notice my ASCII arts skills very developed :D More seriously, I can't screenshot it I'm on linux and the time it takes to screenshot makes the notification disappear

tuomashatakka commented 7 years ago

Cool! (I'm referring to the ascii art 🙂)

Hmm, I think they are supposed to be on the top-left corner, at least I've had them there for as long as I remember. Tried to solve this but since it's done with a single pseudo element, it got a bit hacky at some point, so I gave up. I'd like to do something radical for the notifications anyway, for me they have always bugged me most atom-wise. Any ideas?

alanzanattadev commented 7 years ago

I already like them, just the colloapsing one are annoying, and the icon not aligned. I'm used to use them on the top right corner so I don't have a view on this :)

tuomashatakka commented 7 years ago

This should have been fixed in v0.10.0. All notification icons are now vertically aligned in the middle.