search

tuomassalo / tab-numbering

Browser extension for Chrome and Firefox: add numbering to tab titles
MIT License
28 stars 10 forks source link

fixed small number issue #4

Open nobellium1997 opened 5 years ago

nobellium1997 commented 5 years ago

I just swapped the characters for numbers and put in a space so that it was easier to read.

nobellium1997 commented 5 years ago

refs #2

tuomassalo commented 4 years ago

Hi! Late thanks for the PR. I need to point out that due to the hacky natute of the code and normal numbers being not completely unusual as the first cahracter of a <title>, this change aggravates the known issue "will mess up with titles already starting with the characters ¹...⁸" mentioned in README.

this is the problematic code: whenever tab numbering changes, these lines attempt to remove the old number from the title.

https://github.com/tuomassalo/tab-numbering/blob/d4f3c27d9a81941284ca5e8fca0a511dfd792117/tab-numbering.js#L13-L15

See also: https://github.com/tuomassalo/tab-numbering/commit/64ae5127f939387e3a2dab07042e3afade2f58cc