search

tuomount / Open-Realms-of-Stars

4X Strategy game
GNU General Public License v2.0
134 stars 32 forks source link

Remove hardcoded race diplomacy bonuses #722

Closed BottledByte closed 10 months ago

BottledByte commented 10 months ago

Also removes unused DIPLOMAT_CAPTURED bonus. This change breaks saves.

Some behavioral tests are failing as a consequence, as expected :neutral_face: .

tuomount commented 10 months ago

While reviewing that I had Idea at some point different scored could be given based on realm attitude, so it would reflect then ruler's attitude and aggressive rule might mind that much there has been bad behaviour like war declaration, nuking and such. Then again if ruler changes and peaceful comes, he/she then would not tolerate things like that.

This looks fine. I'll take a look for that behavioral tests. I was expecting that there are test that will definitely fail.

BottledByte commented 10 months ago

While reviewing that I had Idea at some point different scored could be given based on realm attitude, so it would reflect then ruler's attitude and aggressive rule might mind that much there has been bad behaviour like war declaration, nuking and such. Then again if ruler changes and peaceful comes, he/she then would not tolerate things like that.

I had similar idea, where "diplomatic event" (bonus) would be interpreted by AI, to decide how good/bad it is for them. Making Rulers (who may change in time) affecting interpretation of diplomatic bonuses would be a nice feature :+1:.