search

tuomur / python-odata

A simple library for read/write access to OData services
MIT License
79 stars 59 forks source link

ComplexType support #18

Open i39 opened 6 years ago

i39 commented 6 years ago

Hi and thanks for this great library. This is my attempt to make ComplexType support in it.

tuomur commented 6 years ago

Thanks for taking a shot at this, PR looks really good.

But I wish it were that easy. If I remember correctly, the code in complextype.py does not handle nested ComplexTypes properly and the dict-like access is not very elegant compared to the rest of the package. I'm not sure it handles correctly in insert/update situations. It was left kinda... unfinished.

i39 commented 6 years ago

Yes. You right. Thanks for reply. I'm working with it. And, if i'll find elegant solution i'll make another pull request.