search

tupian-language-resources / tuled

TuLeD: Tupían lexical database
Creative Commons Attribution 4.0 International
2 stars 0 forks source link

release #42

Open LanguageStructure opened 3 years ago

LanguageStructure commented 3 years ago

@LinguList @StasReichert I will update the bibliography and run the check again on Friday, then we can release the new version. There are a few concepts without a CONCEPTICON counterpart.

LanguageStructure commented 3 years ago

@LinguList we have finished the error checking. The only errors there are those that you said were caused by the integration with CONCEPTICON (missing concepts).

We have added the CONTRIBUTORS list as a separate worksheet to Google Drive.

I hope Robert can find time to work on the layout.

Tim Wientzek is not part of this version. His name should not be included.

StasReichert commented 3 years ago

There remain a few bibliography errors that will be closed in the next few hours, we are ticking them off one by one.

LinguList commented 3 years ago

Okay, I have now re-run the code. Releasing via zenodo seems okay to me now.

xrotwang commented 3 years ago

This should be corrected: https://github.com/tupian-language-resources/tuled/blob/24c7840985d5c6efbca22e4dfe97ee8022ce51e9/test.py#L14 new language count seems to be 83

LanguageStructure commented 3 years ago

can we wait for Robert? Those requests are important.

On Tue, Aug 17, 2021 at 8:01 PM Johann-Mattis List @.***> wrote:

Okay, I have now re-run the code. Releasing via zenodo seems okay to me now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900515809, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPK7VEZNV7LA7SY3LMKLT5KPWTANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

LanguageStructure commented 3 years ago

In EDICTOR there are 83 languages, I have just checked it

On Tue, Aug 17, 2021 at 8:04 PM Robert Forkel @.***> wrote:

This should be corrected:

https://github.com/tupian-language-resources/tuled/blob/24c7840985d5c6efbca22e4dfe97ee8022ce51e9/test.py#L14 new language count seems to be 83

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900518082, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPKYNFTAI7PX4BBLUN23T5KQC3ANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

LinguList commented 3 years ago

I just fixed teh tests.

LinguList commented 3 years ago

I re-run with a fresh environment now.

xrotwang commented 3 years ago

You can run the tests locally, too, just pytest.

LinguList commented 3 years ago

Yes, I know. I just forgot there were tests.

LinguList commented 3 years ago

Lots of missing concepts, we need a strategy in the future, how to get this going, if you guys keep adding new concepts here. But this is a separate issue for a new version.

LinguList commented 3 years ago

I have updated the data and tests now.

LinguList commented 3 years ago

So releasing is fine by me. The missing concepts would NOT appear now, we restrict them to the ones we have in concepticon. But for future updates, @LanguageStructure and @StasReichert should decide how they want to address concepts: do you want to add new concepts or do you want to stick to one list? If you want to add new ones, I suggest to decide in advance and not do it in an ad-hoc fashion via EDICTOR, as this may also yield concepts being added multiple times with slight variations in the glosses, etc.

LanguageStructure commented 3 years ago

I am OK with the solution that is easier for you. Maybe you can provide us with a list of possible candidates for expanding the lists with. Not all concepts will be suitable for Tupían languages. We can talk about this sometime.

Johann-Mattis List @.***> schrieb am Di. 17. Aug. 2021 um 21:15:

So releasing is fine by me. The missing concepts would NOT appear now, we restrict them to the ones we have in concepticon https://concepticon.clld.org/contributions/Gerardi-2021-414. But for future updates, @LanguageStructure https://github.com/LanguageStructure and @StasReichert https://github.com/StasReichert should decide how they want to address concepts: do you want to add new concepts or do you want to stick to one list? If you want to add new ones, I suggest to decide in advance and not do it in an ad-hoc fashion via EDICTOR, as this may also yield concepts being added multiple times with slight variations in the glosses, etc.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900564159, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPKZD6IZTOTFWMJ7U7DDT5KYMRANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Fabrício Gerardi

LinguList commented 3 years ago

So for me, this can be released now. In the future, I would say that we need to address the following points:

  1. cognate sets (here I think we have quite a few inconsistencies, but these are better handled by adding systematic sound correspondences, which takes some work, so I cannot do it immediately now)
  2. concepts: expansions should have another workflow, we can of course add new lists to concepticon, but this should be coordinated, ideally also by targeting concepts and making sure there are no duplicates

What you may have to do, @LanguageStructure, is adjust the contributors.md, as you wanted to have changes there, right? So if you are done with that, let me know, and I re-run the code tomorrow.

LanguageStructure commented 3 years ago

The contributors list is already on Google sheets

Johann-Mattis List @.***> schrieb am Di. 17. Aug. 2021 um 22:05:

So for me, this can be released now. In the future, I would say that we need to address the following points:

  1. cognate sets (here I think we have quite a few inconsistencies, but these are better handled by adding systematic sound correspondences, which takes some work, so I cannot do it immediately now)
  2. concepts: expansions should have another workflow, we can of course add new lists to concepticon, but this should be coordinated, ideally also by targeting concepts and making sure there are no duplicates

What you may have to do, @LanguageStructure https://github.com/LanguageStructure, is adjust the contributors.md, as you wanted to have changes there, right? So if you are done with that, let me know, and I re-run the code tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900594160, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPK34TNMIPQUU7SWSNK3T5K6JLANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Fabrício Gerardi

LinguList commented 3 years ago

I meant the "editors" in contributors.md. But we need to add the ones from google sheets then also to the languages in cldf.

LanguageStructure commented 3 years ago

The cognacy is being constantly improved, but there is too much data, since Carolina and I ate doing it manually. There are languages that are complicated to figure out sound correspondences might help, but still, expert judgment will be required. Within Tupían there many irregular sound correspondences. We have pla Ned to write an article about it

Fabrício @.***> schrieb am Di. 17. Aug. 2021 um 22:25:

The contributors list is already on Google sheets

Johann-Mattis List @.***> schrieb am Di. 17. Aug. 2021 um 22:05:

So for me, this can be released now. In the future, I would say that we need to address the following points:

  1. cognate sets (here I think we have quite a few inconsistencies, but these are better handled by adding systematic sound correspondences, which takes some work, so I cannot do it immediately now)
  2. concepts: expansions should have another workflow, we can of course add new lists to concepticon, but this should be coordinated, ideally also by targeting concepts and making sure there are no duplicates

What you may have to do, @LanguageStructure https://github.com/LanguageStructure, is adjust the contributors.md, as you wanted to have changes there, right? So if you are done with that, let me know, and I re-run the code tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900594160, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPK34TNMIPQUU7SWSNK3T5K6JLANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Fabrício Gerardi

-- Fabrício Gerardi

LanguageStructure commented 3 years ago

I shall do it tomorrow morning.

Johann-Mattis List @.***> schrieb am Di. 17. Aug. 2021 um 22:29:

I meant the "editors" in contributors.md. But we need to add the ones from google sheets then also to the languages in cldf.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900608414, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPK5RIGA2QUETWB7PTODT5LBBHANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Fabrício Gerardi

LanguageStructure commented 3 years ago

where do I edit the editors?

On Tue, Aug 17, 2021 at 10:30 PM Fabrício @.***> wrote:

I shall do it tomorrow morning.

Johann-Mattis List @.***> schrieb am Di. 17. Aug. 2021 um 22:29:

I meant the "editors" in contributors.md. But we need to add the ones from google sheets then also to the languages in cldf.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900608414, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPK5RIGA2QUETWB7PTODT5LBBHANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

-- Fabrício Gerardi

LinguList commented 3 years ago

CONTRIBUTORS.md, please submit as PR, so I can double-check for the format ;)

LanguageStructure commented 3 years ago

For some reason, I keep getting an error when trying through PR

On Wed, Aug 18, 2021 at 8:24 AM Johann-Mattis List @.***> wrote:

CONTRIBUTORS.md, please submit as PR, so I can double-check for the format ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tupian-language-resources/tuled/issues/42#issuecomment-900852728, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALNZPK5UDM3MEBPDZUXX6ITT5NGY7ANCNFSM5B2M4KNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .