search

tuplejump / cash

The CASsandra Hive handler
34 stars 25 forks source link

Protection against null values in maps. #1

Closed boneill42 closed 10 years ago

boneill42 commented 10 years ago

When running against a CQL table that has maps, the CQLHiveRecordReader attempts to convert the values into ByteBuffers. In the event of a null value, this results in an NPE in the ByteBufferUtil.

This patch protects against that. (tested against a real table against which we are using Shark)

milliondreams commented 10 years ago

I'll merge it today... Thanks for contributing :) On Feb 18, 2014 3:44 AM, "boneill42" notifications@github.com wrote:

When running against a CQL table that has maps, the CQLHiveRecordReader attempts to convert the values into ByteBuffers. In the event of a null value, this results in an NPE in the ByteBufferUtil.

This patch protects against that. (tested against a real table against

which we are using Shark)

You can merge this Pull Request by running

git pull https://github.com/boneill42/cash master

Or view, comment on, or merge it at:

https://github.com/tuplejump/cash/pull/1 Commit Summary

  • Protection against null values in maps.

File Changes

  • M cassandra-handler/src/main/java/org/apache/hadoop/hive/cassandra/input/cql/CqlHiveRecordReader.javahttps://github.com/tuplejump/cash/pull/1/files#diff-0(2)

Patch Links:

Reply to this email directly or view it on GitHubhttps://github.com/tuplejump/cash/pull/1 .