tuplejump / play-yeoman

Play + Yeoman integration sbt and play plugins
Apache License 2.0
237 stars 58 forks source link

Play Yeoman doesn't work with dependency injected router #79

Closed akkie closed 9 years ago

akkie commented 9 years ago

The new Play 2.4 build doesn't work with the dependency injected router. So if I define:

routesGenerator := InjectedRoutesGenerator

in my build.sbt then I get a compile error because the Yeoman controller is an object and not a class.

anotherhale commented 9 years ago

Will this be resolved soon?

Shiti commented 9 years ago

I will look into it this weekend.

Shiti commented 9 years ago

@akkie @anotherhale Can you share a sample application?

anotherhale commented 9 years ago

https://github.com/anotherhale/play-silhouette-angular-seed

Shiti commented 9 years ago

@anotherhale Although I was able to resolve the compile-time error for Yeoman, I was unable to test it. Could you please make the following changes and check if the application works as expected?

Creating a controller class and calling that in the routes file.

class YeomanController extends Controller {
  def index = Yeoman.index
}
GET         /                                @controllers.YeomanController.index
anotherhale commented 9 years ago

@akkie I don't have time to look into this this week. Can you take a look at this?

Thanks, Andy

akkie commented 9 years ago

Yes, I'll look into this tommorrow.

Shiti commented 9 years ago

@akkie @anotherhale Added support and released 0.8.1.