search

tupton / alfred-chrome-history

Search your Google Chrome history in Alfred
198 stars 17 forks source link

Add favicons #10

Closed jberkel closed 8 years ago

jberkel commented 8 years ago

See #2

Unfortunately only the 16x16 size seems to be stored in the database, so it looks quite ugly.

jberkel commented 8 years ago
captura de ecra 2015-12-04 as 12 27 04
tupton commented 8 years ago

I just merged #6, which also touched the query, but merging should be super straightforward: it's just the ORDER BY clause that changed.

Thanks so much for your contribution. With a few minor tweaks to this pr I'd be glad to merge this.

It's a bummer about only having 16x16 icons, but it looks like that's all Chrome ever uses in the UI. Still, it's better than nothing.

jberkel commented 8 years ago

Rebased, and now uses 32x32 icons if possible.

captura de ecra 2015-12-05 as 13 08 50
tupton commented 8 years ago

Awesome work. Nice find with the bigger icons, and thanks for addressing my feedback.