tupui / soroban-versioning

Tansu - Soroban Versioning
https://tansu.dev
Other
4 stars 3 forks source link

dApp commit history #38

Closed 0xExp-po closed 2 months ago

0xExp-po commented 2 months ago
netlify[bot] commented 2 months ago

Deploy Preview for tansu canceled.

Name Link
Latest commit e736ac1e9780259e03e63fb695b6df90c8f6e332
Latest deploy log https://app.netlify.com/sites/tansu/deploys/66e01619cc450c00088a38d2
netlify[bot] commented 2 months ago

Deploy Preview for testnet-tansu ready!

Name Link
Latest commit e736ac1e9780259e03e63fb695b6df90c8f6e332
Latest deploy log https://app.netlify.com/sites/testnet-tansu/deploys/66e016196615700008ffd5a7
Deploy Preview https://deploy-preview-38--testnet-tansu.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 81
Accessibility: 91
Best Practices: 100
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

tupui commented 2 months ago

Thanks, this looks really great! I like the history view 😃 🙌

Starting with a visual review and then I will go through the code in more details once a few things are fixed.

Connect wallet

  • keep display connected wallet

Great fix!

Linked to the connect, I noticed that if you select a project, then connect your wallet, the update config button does not appear. You need to navigate back and select again the project.

Screenshot 2024-09-05 at 22 14 56

On-chain button

Out of scope but maybe you can quickly fix that button when navigating back it does not show properly

Screenshot 2024-09-05 at 22 11 44

Most importantly, the link is broken as it goes to https://stellar.expert/explorer/undefined/contract/undefined. Looks like the previous update broke it as the live version is also broken.

Project name

There is still a duplicate name here

Screenshot 2024-09-05 at 22 11 12

Please just remove the name from the topic component so that it looks like that. The name is enough in the other section. Also please reduce the font weight for the name as it's a bit disproportionate compared to the rest.

Screenshot 2024-09-05 at 12 24 26

History view

Ok this is cool! 😃

  1. Is there some pagination or scrolling logic? We need to show at most a few commits to not have an infinite list there.
  2. Can you highlight the commit which corresponds to the hash on-chain?
  3. Linked to that, it would be good to have a jump to button which would navigate the view to this commit if it's down or on another page.
Screenshot 2024-09-05 at 22 13 23
0xExp-po commented 2 months ago
0xExp-po commented 2 months ago

I've fixed bugs based on your feedback

Add some extra function

tupui commented 2 months ago

Thanks for the updates I could check all that. (Scrolling not sure but can be left for the next step on UI.)

Then it's just missing the jump to latest hash button and working for any project you set. After that we can merge.

0xExp-po commented 2 months ago

I've fixed register bug also, fixed invoking latest sha function in commit record