search

tupui / soroban-versioning

Tansu - Soroban Versioning
https://tansu.dev
Other
4 stars 3 forks source link

Update workflow #45

Closed 0xExp-po closed 2 months ago

0xExp-po commented 2 months ago
netlify[bot] commented 2 months ago

Deploy Preview for tansu canceled.

Name Link
Latest commit b3d7a9edc862ce72b65e6d2a9be26e59148a2585
Latest deploy log https://app.netlify.com/sites/tansu/deploys/66e520227bc06300081c80c4
netlify[bot] commented 2 months ago

Deploy Preview for testnet-tansu ready!

Name Link
Latest commit b3d7a9edc862ce72b65e6d2a9be26e59148a2585
Latest deploy log https://app.netlify.com/sites/testnet-tansu/deploys/66e52022468e0800083e64c0
Deploy Preview https://deploy-preview-45--testnet-tansu.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 78
Accessibility: 88
Best Practices: 92
SEO: 76
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

tupui commented 2 months ago

Thanks, I see a few things.

  1. On the main screen, when there is no config, we get
Screenshot 2024-09-13 at 19 51 29

This message should not appear. And the modal should directly appear.

  1. We do not want to show an empty card like this Screenshot 2024-09-13 at 19 51 41

Just put the project name and a message inside saying that the project is missing a tansu.toml configuration file. Use this message also when we click on project info button on the project page.

  1. When there is no hash, don't say "Get the Latest Sha ...". Instead write, "There is no hash on-chain for this project" Screenshot 2024-09-13 at 19 52 05

Also remove "Get the latest hash on-chain" as there is no user action. Either write a description or do not write anything.

  1. Change the endpoint "commit" to "project"

  2. Screenshot 2024-09-13 at 19 53 25

Put the register button in the middle. E.g. don't use a button for "No project found", just a text and add bellow a button for register a new project.

  1. add tooltips to explain what is "verified maintainer". e.g. "This maintainer is allowed to register new commit hash on-chain". And a tooltip for "verified commit". e.g. "This commit was verified on-chain by a maintainer"

  2. Tell me when you fix the logo so I can check

  3. Add a button to "Jump to latest verified commit". e.g. on the right of "view project info"

  4. If we have a tansu.toml, instead of showing maintainers public addresses, show their name and add a tooltip to show the public addresses

  5. On the main page, remove the block "Look for a project of register one". You can move the button for on-chain to e.g. the navbar. Or make another proposition

  6. I don't think this is useful. What is the idea here?

    Screenshot 2024-09-13 at 20 18 00
0xExp-po commented 2 months ago

I updated code to resolve whole 11 review items