tupui / soroban-versioning

Tansu - Soroban Versioning
https://tansu.dev
Other
4 stars 3 forks source link

Proposal UI #89

Closed 0xExp-po closed 22 hours ago

0xExp-po commented 1 week ago
netlify[bot] commented 1 week ago

Deploy Preview for testnet-tansu ready!

Name Link
Latest commit 7e370ba383d93e619553591ec33b11c08f3bf7df
Latest deploy log https://app.netlify.com/sites/testnet-tansu/deploys/673ef02599a76b0008af3f60
Deploy Preview https://deploy-preview-89--testnet-tansu.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 70
Accessibility: 88
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for tansu canceled.

Name Link
Latest commit 7e370ba383d93e619553591ec33b11c08f3bf7df
Latest deploy log https://app.netlify.com/sites/tansu/deploys/673ef02568daaf00089318f1
tupui commented 1 week ago

Thanks! Here are some feedbacks.

Screenshot 2024-11-14 at 00 47 11

Here say Tansu Governance in the green and remove Tansu DAO system. Tansu is the current project name. Going on Salib should then say Salib Governance.

0xExp-po commented 1 week ago

regarding the title of the voting page, I'd like to say this page is for the all proposal list I mean this is not the proposals only for a project such as Tansu or Salib.

tupui commented 1 week ago

We don't want a page with all the proposals. What can be helpful later is to have groups of projects and yes there it could be helpful to list proposals from many projects.

For now we need one page per project. Same as we have one page information for each project.

0xExp-po commented 1 week ago

okay then each project has several proposals and there is those proposals' list in project proposal page right?

0xExp-po commented 1 week ago

I've fixed all above

tupui commented 5 days ago

Some things I have been thinking about that we should do:

0xExp-po commented 5 days ago

Only show who voted for proposals which are finished (after the time is up) here, where should I display the voters if convenient, can you leave a comment or updating design in figma please? then I can easily understand where I should update and add components

tupui commented 4 days ago

Only show who voted for proposals which are finished (after the time is up) here, where should I display the voters if convenient, can you leave a comment or updating design in figma please? then I can easily understand where I should update and add components

It just means that if proposals are still in Active state, then clicking to see the voters should not show anything (or if you want show a text saying: "Cannot see voters while voting is in progress"). Then once a proposal is in any other state, show the modal as it is right now.

tupui commented 2 days ago

I also noticed that some icons have issues Screenshot 2024-11-20 at 01 26 06 Screenshot 2024-11-20 at 01 26 14

0xExp-po commented 2 days ago

I've fixed all of them

tupui commented 1 day ago

Adding this too:

For the proposals, please use the one I already gave you for the Active status (Add a DAO), then use these for the mockup data.

Title: Support Soroban Domains for maintainers' addresses
Status: Cancelled
IPFS: bafybeifaztpwi4j2jslrbofmifj2teld6aglhny2z6ivjga7vv5thidrr4

Title: Integrate with xlm.sh
Status: Approved
IPFS: bafybeib6ioupho3p3pliusx7tgs7dvi6mpu2bwfhayj6w6ie44lo3vvc4i

Title: Hire design team
Status: Voted
IPFS: bafybeifzgwidr5ppkwplu4g7ckylksscxslgu367bbtrptzhkgdsai6yxa

Title: Use design system from Stellar
Status: Rejected
IPFS: bafybeiafz4gvlwe74n4chp3elpxuogusqsutpj6vrprj5bazrb3yjcru5u

In the backend for now proposals look like this:

#[contracttype]
pub enum ProposalStatus {
    Active,
    Accepted,
    Rejected,
    Cancelled,
}

#[contracttype]
pub struct Proposal {
    pub id: u32,
    pub title: String,
    pub ipfs: String,
    pub voting_ends_at: u64,
    pub voters_approve: Vec<Address>,
    pub voters_reject: Vec<Address>,
    pub voters_abstain: Vec<Address>,
    pub nqg: u32,
    pub status: ProposalStatus,
}
tupui commented 1 day ago

This is still an issue I think

Screenshot 2024-11-20 at 22 41 00