Merge polymer-2 into master

tur-nr / polymer-redux

Polymer bindings for Redux.

https://tur-nr.github.io/polymer-redux

MIT License

440 stars 67 forks source link

Closed tur-nr closed 7 years ago

tur-nr commented 7 years ago

abdonrd commented 7 years ago

How is the status of this?

Thanks in advance! 👏

tur-nr commented 7 years ago

Trying to resolve some breaking changes when updating dependencies and a few housekeeping stuff left to do. Hopefully not too long :)

ronnyroeller commented 7 years ago

@tur-nr Is there anything we can help with upgrading polymer-redux to Polymer 2?

tur-nr commented 7 years ago

@ronnyroeller thanks for offering your help.

So here are the two failures I'm getting, maybe you could help.

Polymer Lint polymer lint is returning warning which won't pass the tests

index.js(149,34) warning [unknown-superclass] - Unable to resolve superclass parent

Documenting the block of code with @polymerMixin or @polymerMixinClass does not prevail.

Firefox Fails

Firefox hangs in the tests. WCT opens firefox but seems like the tests are never loaded or run so the timeout hits failing them.

tur-nr commented 7 years ago

So I managed to fix the linting issue, turns out the @polymerMixin was placed on the wrong block of code so the analyzer wasn't picking it up.

Still no luck on the Firefox hang, but master is currently not testing Firefox through CI so I may go ahead with the merge.

tur-nr commented 7 years ago

v1.0.0 released.