turandai / gaussian_surfels

Implementation of the SIGGRAPH 2024 conference paper "High-quality Surface Reconstruction using Gaussian Surfels".
540 stars 26 forks source link

Principal point and custom dataset #36

Closed robofar closed 4 months ago

robofar commented 4 months ago

Hello.

I have some dataset, and I want to write camera class for it. When it comes to camera object, should prcppoint be expressed in pixels, or unitless? I saw in your code you divide cx and cy with height and width. So, which one is correct? (cx, cy, width, height are expressed in pixels):

  1. self.prcppoint = np.array([self.cx / self.image_width, self.cy / self.image_height])
  2. self.prcppoint = np.array([self.cx, self.cy])
turandai commented 4 months ago

Hi, if your cx, cy, width, height is in same unit, then the first one should be the correct express in this code.