search

turandai / gaussian_surfels

Implementation of the SIGGRAPH 2024 conference paper "High-quality Surface Reconstruction using Gaussian Surfels".
536 stars 26 forks source link

Having True defaults for store_true variables makes the arg always be True #9

Closed Parskatt closed 5 months ago

Parskatt commented 6 months ago

See here: https://github.com/turandai/gaussian_surfels/blob/main/arguments/__init__.py#L19

For example, with_mask will always be true: https://github.com/turandai/gaussian_surfels/blob/main/arguments/__init__.py#L61

I had to set it manually to False in the init.

turandai commented 6 months ago

Hi, I am sorry, it was a bug with the --with_mask argument, it should be fixed now. Please use the '--use_mask 1/0' to try run with/without mask.