search

turanszkij / WickedEngine

3D engine with modern graphics
https://wickedengine.net
Other
5.84k stars 618 forks source link

RT shadow upscaling quality #613

Open trsh opened 1 year ago

trsh commented 1 year ago

Recently I posted an issue with vertical CRT effect & blurriness with FSR2. There is a fix now that makes the scene so much clearer and usable (as it should be). But I think the vertical CRT's is different problem. As matter of fact I get them with no upscale with just RT shadow on. Shadow maps don't have this problem.

2022-12-24_103637

trsh commented 1 year ago

Also when moving around with RT shadows, lots of blinking and pixel moving on edges and beyond

2022-12-24_104253

turanszkij commented 1 year ago

Yes, this is because RT shadows are running on half resolution, and the upscaling for it is not good.

turanszkij commented 1 year ago

Commit https://github.com/turanszkij/WickedEngine/commit/906638c36950872523556d001f8e2e7d4bf645a0 adds an upscale pass to raytraced shadows. Not perfect, but slightly better.

I'm considering that most of these half res effects would be better to always run in full resolution, and FSR2 upscaler to be used for the whole rendering (if needed) instead of having upscaling per effect.

trsh commented 1 year ago

Tnx, I test it as soon as I can

trsh commented 1 year ago

As u said. Slightly better. Maybe an option to use full res would make sense.

2023-01-07_165820