search

turbo124 / Plane2Ninja

Export data from Invoice Plane to Invoice Ninja
MIT License
14 stars 10 forks source link

Transform Quotes #2

Closed karneaud closed 7 years ago

karneaud commented 7 years ago

Was there any particular reason you left out the "quotes" transformations? I have successfully transferred my invoicePlane data to Invoice Ninja with the exception of the quotes....

turbo124 commented 7 years ago

No particular reason, I probably just forgot! It won't be much work to bring this over.

Braunson commented 7 years ago

Any ETA on this? I'm new to InvoicePlane and InvoiceNinja. I'm actually migrating from Fusion Invoice -> InvoicePlane -> InvoiceNinja lol, only way to migrate my data but quotes are important so I can't move over until this is in place. Have you already started on this @turbo124 yet otherwise I'll take a look.

turbo124 commented 7 years ago

@Braunson this is on my list, should be completed shortly.

karneaud commented 7 years ago

This was quite easy to implement though as invoice ninja uses invoice table for quotes with a column "is_quote" or something of the sort that is set to true. It was then a matter of replicating the classes for the invoice

turbo124 commented 7 years ago

@karneaud are you able to PR your changes?

karneaud commented 7 years ago

@turbo124

I should but in the interim https://gist.github.com/karneaud/4eb8f0ba235395bf9ac2b1afb70dec78

but its not thoroughly tested but got the job done

turbo124 commented 7 years ago

@karneaud thanks for this, i'll test the changes and merge. tks!

Braunson commented 7 years ago

Oh wow that was quick, awesome. I'll just be waiting on your merge @turbo124. Thanks @karneaud!

turbo124 commented 7 years ago

6eaa5df

@Braunson this has been implemented and only lightly tested, please let me know your results!

Braunson commented 7 years ago

@turbo124 I ran the updated code, I'm not sure what the download data button is suppose to do it but outputted a bunch of json with no quotes array within it.

turbo124 commented 7 years ago

Invoice Ninja stores Quotes in the invoice table and uses a boolean is_quote for filtering.

Sounds like your data is ready to import!

Braunson commented 7 years ago

Haha oh yeah, apologies!