A micro-optimization in the file handling process within checkpointing in the quantization module specifically in quantize.py. The change involves using os.replace for renaming the temporary file to the final filename, ensuring the operation is atomic.
Risk mitigation is basically the idea here. This eliminates the brief moment where the file might not exist during the renaming process, which while very unlikely could still theoretically result in risk of data loss or inconsistencies. Given we're dealing with quantization, precision everywhere possible seems prudent.
Key Changes:
Replaced os.rename with os.replace to ensure the file rename operation is atomic.
turboderp
commented
8 months ago
A micro-optimization in the file handling process within checkpointing in the quantization module specifically in
quantize.py. The change involves usingos.replacefor renaming the temporary file to the final filename, ensuring the operation is atomic.Risk mitigation is basically the idea here. This eliminates the brief moment where the file might not exist during the renaming process, which while very unlikely could still theoretically result in risk of data loss or inconsistencies. Given we're dealing with quantization, precision everywhere possible seems prudent.
Key Changes:
os.renamewithos.replaceto ensure the file rename operation is atomic.