search

turboladen / playful

A Ruby implementation of UPnP that works with Ruby >= 1.9.x
MIT License
127 stars 18 forks source link

NoMethodError: undefined method `log_class_name=' for Playful:Module #16

Open xam7247 opened 9 years ago

xam7247 commented 9 years ago

I believe log_switch gem has changed, causing playful gem to fail when requiring it:

require 'playful/ssdp'

throws:

NoMethodError: undefined method `log_class_name=' for Playful:Module

MrJoy commented 9 years ago

... and once you fix that you run into the fact that in v. 1.0, log_switch no longer has LogSwitch::Mixin.

turboladen commented 9 years ago

playful should really lock down log_switch to '~> 0.4.0'.

MrJoy commented 9 years ago

Updating playful to use the newer log_switch version was easy enough, although fully validating it was difficult because of the ether poor state of the various test suites.

I've forked the repo -- renamed to Frisky, pared the functionality back to basically just doing SSDP queries, updated the log_switch deep, etc. The functionality I clipped out, given the significant dependency surface area and less well-defined architecture, seems to be better suited to a gem built on top, rather than a big-ball-of-mud.

So if you just need the SSDP portion -- I.E. You tended to do "require 'playful/ssdp'", then my fork may be more suitable -- though I won't have time to deal with test suites until after my wedding in October.

Sent from my iPhone

On Sep 14, 2015, at 9:32 AM, Steve Loveless notifications@github.com wrote:

playful should really lock down log_switch to '~> 0.4.0'.

— Reply to this email directly or view it on GitHub.

turboladen commented 9 years ago

Cool, glad playful at least gave you, @MyJoy, some starting ground to something useful. I never released a release version of the gem because of that lack of tests; I release a pre-release version of the gem because I thought it might prove to be useful to someone and I knew I wasn't going to work on it anymore (work project at an old job).

MrJoy commented 9 years ago

It was immensely helpful, so thank you!

Sent from my iPhone

On Sep 14, 2015, at 1:33 PM, Steve Loveless notifications@github.com wrote:

Cool, glad playful at least gave you some starting ground to something useful. I never released a release version of the gem because of that lack of tests; I release a pre-release version of the gem because I thought it might prove to be useful to someone and I knew I wasn't going to work on it anymore (work project at an old job).

— Reply to this email directly or view it on GitHub.