turboladen / playful

A Ruby implementation of UPnP that works with Ruby >= 1.9.x
MIT License
127 stars 18 forks source link

A missing 'end' token caused the gem (and Thor) to fail #3

Closed mseymour closed 11 years ago

mseymour commented 11 years ago

On line 254 of lib/upnp/control_point/device.rb a new method started without ending the previous one, which caused the following error to appear when running thor -T:

$ thor -T
Couldn't load HTTPI :em_http adapter.
WARNING: unable to load thorfile "/Users/mark/src/upnp/tasks/control_point.thor": /Users/mark/src/upnp/lib/upnp/control_point/device.rb:507: syntax error, unexpected $end, expecting keyword_end
/Users/mark/src/upnp/lib/upnp/control_point.rb:6:in `require_relative'
WARNING: unable to load thorfile "/Users/mark/src/upnp/tasks/search.thor": /Users/mark/src/upnp/lib/upnp/control_point/device.rb:507: syntax error, unexpected $end, expecting keyword_end
/Users/mark/.rvm/rubies/ruby-1.9.3-p286/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require'
No Thor tasks available
turboladen commented 11 years ago

Whoops! And thanks for the pull!

mseymour commented 11 years ago

No problem!

hypexr commented 11 years ago

I get the message shown above:

Couldn't load HTTPI :em_http adapter.

Will the gem still work?

turboladen commented 11 years ago

Yeah, that's just for doing evened SOAP. Those calls will block right now, but that shouldn't inhibit functionality. I still need to hook up the latest httpi gem, which adds support for em_http.

On Jan 29, 2013, at 21:19, hypexr notifications@github.com wrote:

I get the message shown above:

Couldn't load HTTPI :em_http adapter.

Will the gem still work?

— Reply to this email directly or view it on GitHubhttps://github.com/turboladen/upnp/pull/3#issuecomment-12874792.