search

turboladen / tailor

A RubyGem that allows for checking standard styling of Ruby files.
146 stars 18 forks source link

Optimistic pin on log_switch breaks with v1.0.0 #160

Closed jf647 closed 9 years ago

jf647 commented 10 years ago

log_switch released v1.0.0, which removes the LogSwitch::Mixin class. Tailor optimistically pins to '>= 0.3.0' of log_switch, so it automatically picks up v1.0.0 and dies:

PS C:\projects\cookbooks\my_iis_site> bundle exec rake style --trace
rake aborted!
NameError: uninitialized constant LogSwitch::Mixin
C:/opscode/chefdk/embedded/lib/ruby/gems/2.0.0/gems/tailor-1.4.0/lib/tailor/lexer.rb:17:in `<class:Lexer>'

A short term fix is to release Tailor v1.4.1 with a pessimistic pin on log_switch '~> 0.3.0'. This can also be affected by using that pin in a Gemfile that also includes tailor.

I was about to write 'the proper fix is to integrate the new mechanism described by the log_switch author', but having realized that they're both from the same person I assume this is already underway.

jf647 commented 9 years ago

PR has been merged; closing