search

turbolinks / turbolinks-classic

Classic version of Turbolinks. Now deprecated in favor of Turbolinks 5.
MIT License
3.54k stars 431 forks source link

Partial replacement issue. #545

Closed tombroomfield closed 9 years ago

tombroomfield commented 9 years ago

Hi, encountered a strange issue with the partial replacements. ]

I am attempting to change only a single element in a grid, but using the redirect_to :back, change: 'items:31' method. This change causes the height of the element to reduce.

When I do this, the entire app flashes white for an instant, before then rendering the page with distorted elements below it, for instance: screen shot 2015-05-29 at 4 39 37 pm

Scrolling, or causing it to re-render in any way causes it to return to normal.

tombroomfield commented 9 years ago

Okay, more information on this, The rendering issue occurred because the bottom of the grid had no height set, so expanded to fit the children items. When I changed an element, reducing the height, the overall grid also reduced, but failed to render the lower items correctly. I fixed this by settings the grids height to fill the page.

However, I still get a white flash on replace, which is quite jarring, any idea what is causing this?

Thanks,

Thibaut commented 9 years ago

Hard to debug with just a screenshot. Could you link to a live demo? Which browser are you using?

tombroomfield commented 9 years ago

Yeah, I understand how limited my information, apologies for that. Unfortunately the app is private/enterprise so a link i s difficult, Ill see if I can throw together an example application just reproducing this issue and link it back.

Thanks, Tom.

Thibaut commented 9 years ago

Feel free to reopen if you can put together an example app.