search

turbolinks / turbolinks-classic

Classic version of Turbolinks. Now deprecated in favor of Turbolinks 5.
MIT License
3.54k stars 431 forks source link

Ensures that only script tags contained within changed nodes are executed on partial page replacement #618

Closed alecdotninja closed 9 years ago

alecdotninja commented 9 years ago

This fixes the issue I opened earlier, #617. It appears that it may also address #546.

rails-bot commented 9 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @Thibaut (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alecdotninja commented 9 years ago

The specs in 202.17 seem to be failing because of an issue upstream on Rails master.

Thibaut commented 9 years ago

:+1: on the issue.

Will review soon.