turbolinks / turbolinks-classic

Classic version of Turbolinks. Now deprecated in favor of Turbolinks 5.
MIT License
3.54k stars 428 forks source link

Not correctly inferring protocol with SSL, unless force_ssl is set #656

Open chrisvfritz opened 8 years ago

chrisvfritz commented 8 years ago

Just tried the latest turbolinks on a site with SSL and every link on the page produced mixed content errors, resulting in all internal page visits being blocked by the browser. Yikes!

It may also be worth noting that I'm using Turbolinks.enableTransitionCache().

chrisvfritz commented 8 years ago

It looks like that app wasn't forcing SSL in production.rb via config.force_ssl = true. It is now and turbolinks works! I'd hope not too many apps are using SSL without that option, but I think I'll rename the issue instead of closing it, because I'd expect at least one of these to happen:

Deuteu commented 8 years ago

difficult to detect

In my case on http page, turbolink changes it to https in the url so easy to detect but unwanted so second point would be great.