search

turbolinks / turbolinks-classic

Classic version of Turbolinks. Now deprecated in favor of Turbolinks 5.
MIT License
3.54k stars 428 forks source link

fix rails 5 deprecations #671

Closed ajb closed 6 years ago

ajb commented 7 years ago

closes #665

@dhh mentioned (https://github.com/rails/rails/issues/24018#issuecomment-191852988) that the maintainers would be open to releasing a new version of turbolinks-classic that fixes these deprecations, so I humbly submit this PR for review. 😁

nilbus commented 7 years ago

Is this backward-compatible with Rails 4?

aried3r commented 7 years ago

Is this backward-compatible with Rails 4?

Not fully, I think. Module#prepend came with Ruby 2.0 but Rails 4 supports Ruby 1.9.3.

aried3r commented 7 years ago

Ping @rafaelfranca, would you be open to a PR that removes compatibility for Ruby <2, maybe even Rails <4.2?

We cannot yet switch to TL 5 in our project, so we want to keep using TL-classic for the time being.

mmoll commented 6 years ago

what's the status here?

rafaelfranca commented 6 years ago

I'd prefer to not remove support to Rails 4.2 right now. So can we conditionally check the Rails version where it is necessary?

mmoll commented 6 years ago

I can take a look how far I can get, but first #678 would need to get merged.

mmoll commented 6 years ago

hrm, I guess that whole testing stuff should go to 2-5-stable, like this PR?

mmoll commented 6 years ago

please see #679