Closed ajb closed 6 years ago
Is this backward-compatible with Rails 4?
Is this backward-compatible with Rails 4?
Not fully, I think. Module#prepend
came with Ruby 2.0 but Rails 4 supports Ruby 1.9.3.
Ping @rafaelfranca, would you be open to a PR that removes compatibility for Ruby <2, maybe even Rails <4.2?
We cannot yet switch to TL 5 in our project, so we want to keep using TL-classic for the time being.
what's the status here?
I'd prefer to not remove support to Rails 4.2 right now. So can we conditionally check the Rails version where it is necessary?
I can take a look how far I can get, but first #678 would need to get merged.
hrm, I guess that whole testing stuff should go to 2-5-stable, like this PR?
please see #679
closes #665
@dhh mentioned (https://github.com/rails/rails/issues/24018#issuecomment-191852988) that the maintainers would be open to releasing a new version of turbolinks-classic that fixes these deprecations, so I humbly submit this PR for review. 😁