search

turbolinks / turbolinks-classic

Classic version of Turbolinks. Now deprecated in favor of Turbolinks 5.
MIT License
3.54k stars 428 forks source link

fix rails 5 deprecations #679

Closed xprazak2 closed 6 years ago

xprazak2 commented 6 years ago

This continues where #671 left off, I tried to get in touch with the original author but I did not hear back from him. I added conditional checks to keep backward compatibility.

xprazak2 commented 6 years ago

tests failing due to missing Rakefile in 2-5-stable branch

mmoll commented 6 years ago

@rafaelfranca ☝️

jhubert commented 6 years ago

@rafaelfranca Any chance of getting this in? We can fork, but this seems really useful to those of us who've yet to upgrade to Turbolinks 5.

mmoll commented 6 years ago

could there be a 2.5.4 release on rubygems?

jhubert commented 6 years ago

@rafaelfranca Woohoo! Thank you. 💟

rafaelfranca commented 6 years ago

Yes of course. I'll release it tomorrow

mmoll commented 6 years ago

@rafaelfranca I know I'm annoying, but: any news here?

mmoll commented 6 years ago

anybody?

rafaelfranca commented 6 years ago

I still didn't had time to release it, but I'll work on it soon. Meanwhile you can always point to github using bundler (this is one of the best features that bundler has)

rafaelfranca commented 6 years ago

Oh. It was easier than I thought. It 2.5.4 is released now

mmoll commented 6 years ago

@rafaelfranca Thanks a bunch! Because of the way we package our software for nightly RPM/DEB builds it's not easily possible to use git repos in bundler for production builds...