search

turbolinks / turbolinks-ios

Native iOS adapter for building hybrid apps with Turbolinks 5
MIT License
881 stars 92 forks source link

Unable to build using Xcode 9 and Carthage #114

Closed jonlange closed 6 years ago

jonlange commented 7 years ago

It seems like there is an issue building the framework with Xcode 9 via Carthage. I believe the error is related to a test file still referencing Swift 2.3, but it might be due to the Xcode 9 compiler. It would be really nice to get a Swift 4, (or at least Swift 3.2), version so that Xcode 9 use is possible.

zachwaugh commented 7 years ago

Huh, that's really strange. We have been building Turbolinks using Swift 3.2 and Carthage with Xcode 9, but after updating Carthage, I'm seeing the same thing you are. I just pushed a fix (https://github.com/turbolinks/turbolinks-ios/commit/5a9ae2cceed641214c28bdc32005e16d826fb292). Apparently Turbolinks was trying to copy itself into itself during archive, which was causing the failure. This seems to have been there since the beginning, but I'm honestly not sure why it didn't cause an issue until now.

Either way, can you try again from master?

jonlange commented 6 years ago

I was able to build Turbolinks from master with no issues! The archiving copying issue was consistent with what I was experiencing. Eventually the buffer for archive path was overflowing and causing the build to fail. Thank you for fixing!