turbolinks / turbolinks-ios

Native iOS adapter for building hybrid apps with Turbolinks 5
MIT License
880 stars 92 forks source link

`openURL` was deprecated in iOS 10.0 #176

Closed joemasilotti closed 3 years ago

joemasilotti commented 3 years ago

These warnings only occur if the deployment target is set to iOS 10.0 or above.

Turbolinks/Turbolinks/Session.swift:19:30: 'openURL' was deprecated in iOS 10.0 Turbolinks/Turbolinks/Visit.swift:186:38: 'openURL' was deprecated in iOS 10.0

There recommended approach is to replace openURL with open(_: options: completionHandler:).

If I were to submit a PR, would it be reviewed? I understand this project is in a bit of a weird state with Turbo around the corner.

zachwaugh commented 3 years ago

Fixed in Turbo iOS. More info on the new framework here - https://github.com/turbolinks/turbolinks-ios/pull/178