Ensure ColdBootVisit has completed successfully before calling visitDidInitializeWebView

turbolinks / turbolinks-ios

Native iOS adapter for building hybrid apps with Turbolinks 5

MIT License

881 stars 92 forks source link

Ensure ColdBootVisit has completed successfully before calling visitDidInitializeWebView #45

Closed packagethief closed 7 years ago

packagethief commented 8 years ago

A ColdBootVisit completes successfully when it receives WebViewPageLoadDelegate's webView(_:didLoadPageWithRestorationIdentifier) message. This message originates from the web view's Turbolinks adapter, implying that Turbolinks was successfully loaded and can communicate over the JavaScript bridge.

Until we've received this message, we really can't be sure Turbolinks is installed and working, and shouldn't consider the web view initialized.

joelmoss commented 7 years ago

@packagethief What is the status of this? Any plans to have it merged and a new release cut?

packagethief commented 7 years ago

@joelmoss oops, status was "forgotten." Thanks for the reminder! I'll merge now and cut a new release shortly.

joelmoss commented 7 years ago

👍