Turbolinks fails to build when using cocoapods in Xcode 8.1

turbolinks / turbolinks-ios

Native iOS adapter for building hybrid apps with Turbolinks 5

MIT License

881 stars 92 forks source link

Turbolinks fails to build when using cocoapods in Xcode 8.1 #85

Closed mityakoval closed 7 years ago

mityakoval commented 7 years ago

I'm trying to build my test project with Turbolinks module using cocoapods. However, it raises 105 errors when I'm doing that. screen shot 2016-12-07 at 18 03 53

zachwaugh commented 7 years ago

Looks like a mismatch between Swift versions. What version of Swift are you using in your project? Turbolinks currently supports Swift 2.3, and there is a Swift 3.0 branch as well swift-3.0.

mityakoval commented 7 years ago

@zachwaugh Yeah, I kind of suspected it but managed to fix it just now :) Changed the build settings 'Use Legacy Swift Language Version' => 'Yes'. Everything seems to be building and I can import Turbolinks module now.

Just a brief question: when are you going to merge swift-3.0 branch with master

zachwaugh commented 7 years ago

@mityakoval we'll be merging swift-3.0 into master soon, currently testing it in internal builds now to make sure there are no regressions, but it's stable.

MrHubble commented 7 years ago

@mityakoval did you change the build settings 'Use Legacy Swift Language Version' => 'Yes' under your project settings or is it something to do with Turbolinks directly? I've changed it myself for my project but Turbolinks still has build errors.

screen shot 2017-02-20 at 4 10 37 pm

MrHubble commented 7 years ago

Update: I have it working now but am unsure which of the below steps fixed it:

updated Sierra to 10.12.3 (I was on an older version of Sierra)
updated xcode to 8.2.1 (I was previously on 8.1.x)
created a new project and changed Use Legacy Swift Language Version to Yes before adding Turbolinks with cocoapods

mityakoval commented 7 years ago

@MrHubble Well, my not really educated guess would be the latter two :)