search

turbomanage / storm-gen

Simple ORM for Android SQLite
Apache License 2.0
83 stars 15 forks source link

Enhancement: Remove Warnings #23

Open inalawg opened 10 years ago

inalawg commented 10 years ago

All stORM generated classes have various warnings from

Certain projects mandate no visible warnings and all have them have either been dealt with or the warnings are suppressed after careful review. Since stORM acts like a third party and we cannot update the generated, code it would be good if the FTL files are updated such that warnings are ignored and eclipse renders the classes clean

Note: 3 classes marked with @Entity generated 119 warnings

turbomanage commented 10 years ago

In my generated DAO classes, I see only unused imports for various type converters, which is an artifact from a previous design. What else are you seeing?

On Sun, Apr 27, 2014 at 8:52 PM, inalawg notifications@github.com wrote:

All stORM generated classes have various warnings from

  • Unused imports
  • Use of deprecated classes
  • Raw vs. Generic references
  • ...

Certain projects mandate no visible warnings and all have them have either been dealt with or the warnings are suppressed after careful review. Since stORM acts like a third party and we cannot update the generated, code it would be good if the FTL files are updated such that warnings are ignored and eclipse renders the classes clean

Note: 3 classes marked with @Entity https://github.com/Entity generated 119 warnings

— Reply to this email directly or view it on GitHubhttps://github.com/turbomanage/storm-gen/issues/23 .

inalawg commented 10 years ago

From the top 100, here are the most common ones. Occurrences of deprecation / type safety / raw types are next after the unused imports

The import com.turbomanage.storm.types.LongConverter is never used TodoListDao.java The import com.turbomanage.storm.types.BooleanConverter is never used TodoListDao.java The import com.turbomanage.storm.types.IntegerConverter is never used TodoListDao.java The import com.turbomanage.storm.types.StringConverter is never used TodoListDao.java The type DatabaseUtils.InsertHelper is deprecated TodoListTable.java The method bindNull(int) from the type DatabaseUtils.InsertHelper is deprecated TodoListTable.java The import java.util.HashMap is never used TodoListTable.java The import com.turbomanage.storm.SQLiteDao is never used TodoListTable.java FilterBuilder is a raw type. References to generic type FilterBuilder should be parameterized TodoListTable.java Type safety: The return type FilterBuilder for buildFilter(FilterBuilder, TodoList) from the type TodoListTable needs unchecked conversion to conform to FilterBuilder from the type TableHelper TodoListTable.java