turbomanage / storm-gen

Simple ORM for Android SQLite
Apache License 2.0
83 stars 15 forks source link

Update CsvTableReader.java #31

Closed Gopinathp closed 10 years ago

Gopinathp commented 10 years ago

Fixed an issue with upgrades where id could be negative. E.g: My db table's id is based on hashCode() of a String (TICKET_ID)

turbomanage commented 10 years ago

I'm surprised you can have negative IDs in SQLite and surprised that doesn't create other problems in stORM. Still, the SQLite DatabaseUtils.InsertHelper docs say that -1 is the value returned in the case of an error, so I don't see any harm in this change.