[TRB-44809]: Removed "placed" flag. Updated short-circuit IF statement.

[amd-ibm]

Intent

Fix an issue where Reconfigure actions are not generating when there is no supplier for an affinity commodity.

Background

Recent changes to affinity processing broke the logic that would cause Reconfigure actions in the following scenarios:

• pod-to-node affinity: if zero nodes match the node affinity for the Running workload, it should generate a reconfigure action.
• pod-to-pod affinity: if the Pod to which an other workload has affinity to is removed, a Reconfigure action should be generated due to the affinity constraints being unmet.

Testing

Ran kubeturbo against ROSA cluster and tested the following scenarios:

Pod-to-Node Affinity

Deployed a WorkloadController with node affinity. Once Pod was Running, removed the label from the node, ran rediscovery and broadcasted. Verified that a Reconfigure action is generated.

Pod-to-Pod Affinity

Deployed a WorkloadController with affinity to a bare Pod. Once they were running, removed the bare Pod, ran rediscovery and broadcasted. Verified that a Reconfigure action is generated.

Checklist

These are the items that must be done by the developer and by reviewers before the change is ready to merge. Please strikeout any items that are not applicable, but don't delete them

• [ ] Developer Checks
  • [x] Full build with unit tests and fmt and vet checks
  • [ ] Unit tests added / updated
  • [ ] No unlicensed images, no third-party code (such as from StackOverflow)
  • [ ] Integration tests added / updated
  • [x] Manual testing done (and described)
  • [ ] Product sweep run and passed
  • [ ] Developer wiki updated (and linked to this description)
• [ ] Reviewer Checks
  • [ ] Merge request description clear and understandable
  • [ ] Developer checklist items complete
  • [ ] Functional code review (how is the code written)
  • [ ] Architectural review (does the code try to do the right thing, in the right way)
  • [ ] Defensive coding (incoming data checked / sanitized, exceptions logged, clear error messages)
  • [ ] No unlicensed images, no third-party code (such as from StackOverflow)
  • [ ] Security review checklist complete.

Audience

@irfanurrehman @andreiastra

[pankajbatra1]

Can you please verify the behavior once the removed label/bare pod is brought back?

[amd-ibm]

Can you please verify the behavior once the removed label/bare pod is brought back?

@pankajbatra1 , I verified that both reconfigure actions disappear if the label is added back, or the pod to which the workload has affinity is recreated.