To update cluster role permissions in the CSV file, we utilize the ruamel Python library. This library must be installed in the Python environment for the script to execute successfully.
Removal of Access token usage for GitHub API call
Background
The import of this library was previously unsuccessful because the installation step was omitted. With this modification, the system will verify if there's a problem importing the library. If an issue arises, it will then install the library into the Python environment, ensuring the script runs successfully.
The reason for removing the Access Token in the GitHub API call is multifaceted. Firstly, we intend to globalize the validation of the Access Token, allowing other variables to utilize it. Its current setup inadvertently impacts other make commands, as they incorrectly expect the presence of a token. Furthermore, the GitHub API's rate limit for unauthorized requests stands at 60 requests per hour. In practical scenarios, this limit should be enough to support our processes.
Execution Instructions
Utilize the make command: make build-certified-operator-bundle
A model command for launching a certified operator bundle in a stable release: make build-certified-operator-bundle OPERATOR_RELEASE_VERSION=1.2.3 OPERATOR_RELEASE_CHANNEL=stable
A model command for launching a certified operator bundle in a beta release: make build-certified-operator-bundle OPERATOR_RELEASE_VERSION=1.2.3 OPERATOR_RELEASE_CHANNEL=beta
Note: - No need to pass ACCESS_TOKEN as input parameter when executing the command
Testing
Before:
After:
Checklist
These are the items that must be done by the developer and by reviewers before the change is ready to merge. Please strikeout any items that are not applicable, but don't delete them
[ ] Developer Checks
[ ] Full build with unit tests and fmt and vet checks
[ ] Unit tests added / updated
[ ] No unlicensed images, no third-party code (such as from StackOverflow)
[ ] Integration tests added / updated
[x] Manual testing done (and described)
[ ] Product sweep run and passed
[ ] Developer wiki updated (and linked to this description)
[ ] Reviewer Checks
[ ] Merge request description clear and understandable
[ ] Developer checklist items complete
[ ] Functional code review (how is the code written)
[ ] Architectural review (does the code try to do the right thing, in the right way)
Intent
Background
Execution Instructions
Note: - No need to pass ACCESS_TOKEN as input parameter when executing the command
Testing
Before:
After:
Checklist
These are the items that must be done by the developer and by reviewers before the change is ready to merge. Please
strikeoutany items that are not applicable, but don't delete themAudience
(@ mention any
review/...
groups or people that should be aware of this merge request)