TRB-43347 Disable scaling for eks spot and windows instance

[alvinc78]

Intent

Disable scaling for eks spot instance Disable scaling for windows instance

Background

We don't support these instances to be suspended or provisioned but the UI shows the actions, we want to disable that for the nodes.

Testing

Checklist

These are the items that must be done by the developer and by reviewers before the change is ready to merge. Please strikeout any items that are not applicable, but don't delete them

• [ ] Developer Checks
  • [ ] Full build with unit tests and fmt and vet checks
  • [ ] Unit tests added / updated
  • [ ] No unlicensed images, no third-party code (such as from StackOverflow)
  • [ ] Integration tests added / updated
  • [ ] Manual testing done (and described)
  • [ ] Product sweep run and passed
  • [ ] Developer wiki updated (and linked to this description)
• [ ] Reviewer Checks
  • [ ] Merge request description clear and understandable
  • [ ] Developer checklist items complete
  • [ ] Functional code review (how is the code written)
  • [ ] Architectural review (does the code try to do the right thing, in the right way)
  • [ ] Defensive coding (incoming data checked / sanitized, exceptions logged, clear error messages)
  • [ ] No unlicensed images, no third-party code (such as from StackOverflow)
  • [ ] Security review checklist complete.

Audience

[tian-ma]

Are you going to add a unit test here https://github.com/turbonomic/kubeturbo/blob/92f550541093aeb3d13f2de2609055668c3efb81/pkg/discovery/dtofactory/node_entity_dto_builder_test.go#L208

seeing how complex this is, it maybe simpler to separate the extra logic into its own function and make a unit test for the small function.

[alvinc78]

Are you going to add a unit test here

https://github.com/turbonomic/kubeturbo/blob/92f550541093aeb3d13f2de2609055668c3efb81/pkg/discovery/dtofactory/node_entity_dto_builder_test.go#L208

seeing how complex this is, it maybe simpler to separate the extra logic into its own function and make a unit test for the small function.

I have moved this to a function itself

[alvinc78]

Are you going to add a unit test here

https://github.com/turbonomic/kubeturbo/blob/92f550541093aeb3d13f2de2609055668c3efb81/pkg/discovery/dtofactory/node_entity_dto_builder_test.go#L208

seeing how complex this is, it maybe simpler to separate the extra logic into its own function and make a unit test for the small function.

added unit test