turbonomic / t8c-install

23 stars 35 forks source link

[TRB-52140]: Introduced new configurations (systemWorkloadDetectors & exclusionDetectors) for Kubeturbo. #44

Closed amd-ibm closed 10 months ago

amd-ibm commented 11 months ago

Introduced new configurations (systemWorkloadDetectors & exclusionDetectors) for Kubeturbo.

irfanurrehman commented 11 months ago

Tested this, had some issues and needed changes. The fix for the issues is pushed as the last commit on this PR (https://github.com/turbonomic/t8c-install/pull/44/commits/f1a855c53273a2aedd5e81bed2007ce96ba6080f)

Test result: Build the xl operator from the branch and after installing xl using the new operator build below is the configmap data:

 k get cm turbo-config-xl-release -n irf1 -o yaml
I1123 00:43:08.463714   29089 versioner.go:56] Remote kubernetes server unreachable
apiVersion: v1
data:
  turbo-autoreload.config: |2-

    {
      "systemWorkloadDetectors": {
        "namespacePatterns": ["kube-.*","openshift-.*","cattle.*"]
      },
      "exclusionDetectors": {
        "operatorControlledWorkloadsPatterns": [],
        "operatorControlledNamespacePatterns": []
      }
    }
  turbo.config: |-
    {
      "communicationConfig": {
        "serverMeta": {
          "version": "8.10.6-SNAPSHOT",
          "turboServer": "http://topology-processor:8080"
        },
        "restAPIConfig": {
          "opsManagerUserName": "Turbo_username",
          "opsManagerPassword": "Turbo_password"
        }
      },
      "HANodeConfig": {
        "nodeRoles": ["master"]
      },
      "targetConfig": {
        "targetName": "Turbonomic"
      }
    }
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: xl-release
    meta.helm.sh/release-namespace: irf1
  creationTimestamp: "2023-11-22T13:40:59Z"
....

Logged into the kubeturbo container and the dynamic config data is correct there too

sh-4.4$ ls -l /etc/kubeturbo
total 0
lrwxrwxrwx 1 root 2000 30 Nov 22 13:41 turbo-autoreload.config -> ..data/turbo-autoreload.config
lrwxrwxrwx 1 root 2000 19 Nov 22 13:41 turbo.config -> ..data/turbo.config

turbo-autoreload.config data

sh-4.4$ cat /etc/kubeturbo/turbo-autoreload.config

{
  "systemWorkloadDetectors": {
    "namespacePatterns": ["kube-.*","openshift-.*","cattle.*"]
  },
  "exclusionDetectors": {
    "operatorControlledWorkloadsPatterns": [],
    "operatorControlledNamespacePatterns": []
  }
}
amd-ibm commented 10 months ago

May reopen in the future