search

turbos-finance / turbos-clmm-sdk

6 stars 5 forks source link

Bump sui sdk to 0.54.1 #23

Closed ronanyeah closed 3 months ago

ronanyeah commented 3 months ago

Some unknown typing needed to be added as MoveStruct wasn't mapping directly to the Turbos interfaces.

runcat1234567 commented 3 months ago

Thank you for your effort, the commit message should to be changed with format: fix: getObjectFields returning type is MoveStruct or something . It's unnecessary to upgrade sui.js/client to 0.54 in favor of interface MoveStruct is available at a lower version such as 0.44.

runcat1234567 commented 3 months ago

Would you please force push this commit again?

runcat1234567 commented 3 months ago

And don't forget to update pnpm-lock.yaml by command pnpm install if you want to update dependencies in package.json

ronanyeah commented 3 months ago

Looks like the sui.js npm package is now deprecated: https://x.com/HesJustJordy/status/1796273699911557190

Here's the new one: https://www.npmjs.com/package/@mysten/sui

runcat1234567 commented 3 months ago

Well, a new PR is created: https://github.com/turbos-finance/turbos-clmm-sdk/pull/24