turbot / flowpipe

Flowpipe is a cloud scripting engine. Automation and workflow to connect your clouds to the people, systems and data that matters.
https://flowpipe.io
GNU Affero General Public License v3.0
383 stars 16 forks source link

Should messages from `error_message()` be formatted/trimmed? #324

Closed cbruno10 closed 8 months ago

cbruno10 commented 11 months ago

For this output: https://github.com/turbot/flowpipe-mod-aws/blob/7a2c62a6eeb472fd7bc93295ddcd85f339fa54af/pipelines/s3/tests/test_create_s3_bucket.fp#L81

I’m seeing this output:

[test_create_s3_bucket] Output bucket = flowpipe-test-33cfd5e3-b973-8fd6-91e2-2ba4f6212ee2
[test_create_s3_bucket] Output test_results = {
  "create_s3_bucket": "pass",
  "delete_s3_bucket": "pass",
  "list_s3_buckets": "fail: \nCould not connect to the endpoint URL: \"https://s3.us-yyy-3.amazonaws.com/\"\n"
}
[test_create_s3_bucket] Complete 4s

In the logs above, I see the error (expected, was testing it failing by passing in a region of “us-yyy-3” into the list_s3_buckets step):

2023-11-27T15:31:04.918-0500    INFO    container create    {"elapsed": "16.961584ms", "image": "public.ecr.aws/aws-cli/aws-cli", "container": "663075f27810d3d9a3401da542809c2d0342f27cdee9f76fa828374bef8773fe"}
[list_s3_buckets.list_s3_buckets] Execution Error:
Could not connect to the endpoint URL: "https://s3.us-yyy-3.amazonaws.com/"

[list_s3_buckets.list_s3_buckets] Failed with 1 error(s) 2s
[list_s3_buckets] Failed with 1 error(s) 2s
2023-11-27T15:31:05.089-0500    INFO    container start {"elapsed": "170.547125ms", "image": "public.ecr.aws/aws-cli/aws-cli", "container": "663075f27810d3d9a3401da542809c2d0342f27cdee9f76fa828374bef8773fe"}
[test_create_s3_bucket.list_s3_buckets] Execution Error:
Could not connect to the endpoint URL: "https://s3.us-yyy-3.amazonaws.com/"

[test_create_s3_bucket.list_s3_buckets] Failed with 1 error(s) 2s
github-actions[bot] commented 9 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 8 months ago

This issue was closed because it has been stalled for 90 days with no activity.