turbot / flowpipe

Flowpipe is a cloud scripting engine. Automation and workflow to connect your clouds to the people, systems and data that matters.
https://flowpipe.io
GNU Affero General Public License v3.0
327 stars 9 forks source link

File watching does not detect change inside loop block of input step? #820

Closed e-gineer closed 5 days ago

e-gineer commented 3 months ago

Version: v0.4.3-rc.2

I have this step:

  step "input" "approve" {
    notifier = notifier[param.approvers[0]]

    type = "button"

    subject = param.subject

    prompt = param.prompt

    option "approve" {
      label = "Approve"
      style = "ok"
    }

    option "deny" {
      label = "Deny"
      style = "alert"
    }

    loop {
      until = result.value == "deny" || loop.index >= length(param.approvers) - 1
      notifier = notifier[param.approvers[loop.index]]
    }

    output "approved" {
      value = self.value == "approve"
    }

  }

When I change the loop until attribute (e.g. add or remove the - 1), the file watching does not detect the change.

File watching works and reloads for changes to the option style attribute (as expected).

vhadianto commented 3 months ago

Fixed in pipe-fittings: https://github.com/turbot/pipe-fittings/commit/27d7c5981ed93174ea8d6c76ca008b1c16276e7c

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

github-actions[bot] commented 5 days ago

This issue was closed because it has been stalled for 90 days with no activity.