turbot / powerpipe

Powerpipe: Dashboards for DevOps. Visualize cloud configurations. Assess security posture against a massive library of benchmarks. Build custom dashboards with code.
https://powerpipe.io/
GNU Affero General Public License v3.0
228 stars 16 forks source link

Failed mod install might still do a mod init (without telling me) #246

Closed e-gineer closed 5 months ago

e-gineer commented 5 months ago

I tried installing a mod before it was tagged ... was surprised to find a mod.pp file had been created despite the error.

Perhaps we should at least log to the screen that we've initialized the mod?

~/src $ mkdir rna && cd rna
~/src/rna $ powerpipe mod install https://github.com/turbot/powerpipe-mod-rnacentral
Error: 1 dependency failed to install - no version of github.com/turbot/powerpipe-mod-rnacentral found satisfying version constraint: *
~/src/rna $ 
~/src/rna $ cd ..
~/src $ 
~/src $ rmdir rna
rmdir: rna: Directory not empty
~/src $ 
~/src $ cd rna/
~/src/rna $ ls
mod.pp
~/src/rna $ cat mod.pp 
mod "local" {
  title = "rna"
}
kaidaguerre commented 5 months ago

@e-gineer would we prefer the mod.pp was not created at all in this case?